[pmwiki-users] [PATCH] Issue with pmwiki and PHP virtual() function (SSI)

Patrick R. Michaud pmichaud at pobox.com
Thu Nov 10 08:01:20 CST 2005

On Thu, Nov 10, 2005 at 02:51:55PM +0100, Mikael Nilsson wrote:
> >However, PmWiki already has the $FarmD variable, which is set to
> >the value of the installation directory of the pmwiki.php script.
> I noticed that, but I couldn't really understand why $FarmD uses 
> dirname(__FILE__) but WorkDir only says 'wiki.d'. Are there cases when 
> $FarmD/wiki.d != $WorkDir?

Yes, when running a WikiFarm, $FarmD holds the location of the PmWiki
installation, while the current directory contains the files and
scripts for just the current field.

> >>The one remaining thing I had to do was to was to remove the 
> >>"clear:both" CSS directive in pagerev.php. [...] Is that directive 
> >>really needed for anything? To me it looks ok without...
> >
> >Without it there can be problems with displaying
> >floating images in the page history -- see
> >http://www.pmwiki.org/wiki/Test/FloatDiff for an example.
> >
> >The real solution may be for PmWiki to go back to using
> >tables for the page history.  OTOH, we may just re-do the
> >entire page history format.  :-)
> :-) or just wrap the whole history in one container table? I'm not sure 
> if clear:both reaches outside the table... Maybe it does.

That would probably work, but if we're going to resort to
a table *anyway*, we might as well make each revision item
into its own table cell and then the clear:both isn't needed
at all.  :-)


More information about the pmwiki-users mailing list