[pmwiki-users] [PATCH] Issue with pmwiki and PHP virtual() function (SSI)

[Mikael Nilsson]

Patrick R. Michaud wrote:
>>
>>I still wonder if it would be better if pmwiki.php stored cwd at the top 
>>of the file and then used the stored value later, but that's your choice...
> 
> 
> That's a good idea, but unfortunately one cannot reliably use
> getcwd() in every PHP environment.  Sometimes the file permissions
> on the server prevent getcwd() from returning the current directory,
> and on some environments it just doesn't work.

Oh...

> However, PmWiki already has the $FarmD variable, which is set to
> the value of the installation directory of the pmwiki.php script.

I noticed that, but I couldn't really understand why $FarmD uses 
dirname(__FILE__) but WorkDir only says 'wiki.d'. Are there cases when 
$FarmD/wiki.d != $WorkDir?


> 
>>The one remaining thing I had to do was to was to remove the 
>>"clear:both" CSS directive in pagerev.php. Otherwise the changes would 
>>not show until under my left sidebar (my site is CSS-based, so my 
>>sidebar uses margins and floats). Is that directive really needed for 
>>anything? To me it looks ok without...
> 
> 
> Without it there can be problems with displaying
> floating images in the page history -- see
> http://www.pmwiki.org/wiki/Test/FloatDiff for an example.

I see. Not a big issue for me, so I'll just live with my modifications...

> 
> The real solution may be for PmWiki to go back to using
> tables for the page history.  OTOH, we may just re-do the
> entire page history format.  :-)

:-) or just wrap the whole history in one container table? I'm not sure 
if clear:both reaches outside the table... Maybe it does.

Well, well, many thanks anyway.

/Mikael


-- 
Plus ça change, plus c'est la même chose
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mini.vcf
Type: text/x-vcard
Size: 244 bytes
Desc: not available
Url : /pipermail/pmwiki-users/attachments/20051110/7754c0cb/attachment.vcf