[Pmwiki-users] typo fix in stdconfig.php

[Patrick R. Michaud]

Thanks, you're correct -- it's a bug, and the patch is greatly
appreciated.  Fixed in the next release (coming soon).

Pm


On Tue, May 25, 2004 at 02:20:23PM -0700, Ben Shakal wrote:
> 
>    Hi,
> 
> 
> 
>    I've  been  experimenting  with  my  own diff formatting (highlighting
>    individual words instead of / in addition to whole lines), so I copied
>    scripts/pagerev.php   into   my   local/  dir  and  included  it  from
>    local/config.php  .   But  then  I  got  PHP  errors  about redefining
>    printdiff()  .   The  official  pagerev.php  was still being included,
>    though  it  appears  to  auto-disable  itself in stdconfig.php.  I was
>    about  to  comment it out of stdconfig.php, which would of course work
>    fine  until  it  came  time  for  an  upgrade, but it appears that the
>    auto-disabling is failing because of a simple typo... with a tweak, it
>    works  fine.  As far as I can tell via my friend grep, HandleBrowse is
>    actually a function, not a global array, so I don't think there is any
>    existing (intended or not) functionality that this change will affect.
> 
> 
> 
>    Here is a patch for 0.6.x :
> 
> 
> 
> 
> 
>    --- scripts/stdconfig.php.orig  Thu Feb 26 10:27:23 2004
>    +++ scripts/stdconfig.php       Tue May 25 13:34:07 2004
>    @@ -31,7 +31,7 @@
>       include_once("scripts/print.php");
>     if (!isset($EnableTemplateLayout) || $EnableTemplateLayout)
>       include_once("scripts/tlayout.php");
>    -if ($action=='diff' && @!$HandleBrowse['diff'])
>    +if ($action=='diff' && @!$HandleActions['diff'])
>       include_once("scripts/pagerev.php");
>     if (!isset($EnableQAMarkup) || $EnableQAMarkup)
>       include_once("scripts/faq.php");
> 
> 
> 
> 
> 
> 
> 
>    (Please let me know if this is not the appropriate means of submitting
>    a patch...)
> 
>    Thanks,
> 
>    -Ben
> 
>    ----
>    Ben Shakal
>    Web Engineer
>    [[http://www.sixg.com/ sixG inc]]

> -- 
> Pmwiki-users mailing list
> Pmwiki-users at pmichaud.com
> http://pmichaud.com/mailman/listinfo/pmwiki-users_pmichaud.com