[pmwiki-users] USe PTVs instead of directives (was (:title:) of (:include:) included pages overrides page title)
Eemeli Aro
eemeli at gmail.com
Wed Feb 25 14:20:30 CST 2009
2009/2/25 Kathryn Andersen <kat_lists at katspace.homelinux.org>:
> On Wed, Feb 25, 2009 at 07:30:51PM +0200, Eemeli Aro wrote:
>> So, this is what I propose:
>>
>> 1) Remove the special markup for the page title, description and keywords.
>> The current/old markup can be added to $PageTextVarPatterns and
>> $ROEPatterns to make the transition relatively painless.
>
> My earlier objections to this still stand.
> They aren't ordinary PTVs, so they shouldn't use the same markup,
> because that adds to the confusion.
> (And it would break my site)
Ah, weirdness. Since version 2.1.beta37, (:title:) and the other
directives do in fact set the corresponding page text variables, but
their markup is processed after {$var} expansion so this isn't evident
unless you're poking at things in the code. I hadn't noticed this
before.
And I agree that they aren't page text variables, but my point is that
they ought to be. Can you explain a bit more how this breaks your
site? Is it just a matter of having similarly-named page text
variables on your site?
> Are you saying save every single PTV as a page attribute, or just title,
> description and keywords?
No, just the ones in $SaveProperties, which is by default set to
array('title', 'description', 'keywords').
eemeli
More information about the pmwiki-users
mailing list