[pmwiki-users] Re: David Spitzley's commentsmailed.php

Patrick R. Michaud pmichaud at pobox.com
Fri Dec 2 17:14:35 CST 2005


On Fri, Dec 02, 2005 at 04:35:36PM -0600, Tegan Dowling wrote:
>    Now that PM has added PITS /00563 (Don't show ?action= links to web
>    spiders/robots) to 2.1.beta8, this problem with the commentsmailed recipe
>    may go away. 
>
>    I'm holding at version 2.012 on my wikis for now, so won't know for a
>    while - is there anybody who knows or can tell?

It might be reduced, but I doubt it will go away completely.  There will 
always be some robots which PmWiki won't detect as being robots.

But beyond that, I think that commentsmailed ought to be able to
figure out when to update mailposts based on $_POST['action'].
I haven't been able to figure out some sections of the code, but
it seems to me that it should update mailposts only when
$_POST['action'] is set.  

Robots (well behaved ones, at least) only access pages using 
GET requests, while comments are only added in response to POST
requests.  So, if the mailposts file (and possibly .Comment) is 
updated only when $_POST['action'] is set, that ought to eliminate
robot false positives.

Pm




More information about the pmwiki-users mailing list