[pmwiki-users] Cookbook Recipe Attachtable problem

Monte Padget m_padget at hotmail.com
Thu Jul 6 17:35:29 CDT 2017


That worked!


I was just trying an old version I still had locally and it is working there and I have more than 8 pages in the group.


The infinite loop makes sense, I had set $EnableDiag = 1; and was getting a memory error on the server. On my local I was getting a 30 second timeout.


Thank you,

Monte


________________________________
From: pmwiki-users <pmwiki-users-bounces at pmichaud.com> on behalf of Petko Yotov <5ko at 5ko.fr>
Sent: Thursday, July 6, 2017 4:21 PM
To: Pmwiki Users
Subject: Re: [pmwiki-users] Cookbook Recipe Attachtable problem

There is an infinite loop somewhere when a markup directive called by
MarkupToHTML calls MarkupToHTML itself (attachtable.php line 169). To
the server quickly runs out of memory with a fatal PHP error or a 500
Internal Server Error, or with 503 Service Unavailable. On production
servers you may not see the error message but a blank page.

This fixes it, in config.php, before the "switch" line:

   $AttachtableProperReferenceLookupMaxPages = 0;

This way Attachtable will use its own function to search for file links,
instead of calling MarkupToHTML. This is the default setting if there
are more than 8 pages in your group. I assume most people have more
pages and have not noticed the bug.

Petko

---
Change log     :  http://www.pmwiki.org/wiki/PmWiki/ChangeLog
PmWiki | PmWiki / ChangeLog<http://www.pmwiki.org/wiki/PmWiki/ChangeLog>
www.pmwiki.org
See the cookbook recent changes page for additional updates and activity by other developers, or join the PmWiki mailing lists to discuss feature development with us.


Release notes  :  http://www.pmwiki.org/wiki/PmWiki/ReleaseNotes
PmWiki | PmWiki / Release Notes<http://www.pmwiki.org/wiki/PmWiki/ReleaseNotes>
www.pmwiki.org
Version 2.2.96 (2017-04-05) This version fixes a severe PHP code injection vulnerability, reported by Gabriel Margiani. PmWiki versions 2.2.56 to 2.2.95 are concerned.


If you upgrade :  http://www.pmwiki.org/wiki/PmWiki/Upgrades
PmWiki | PmWiki / Upgrades<http://www.pmwiki.org/wiki/PmWiki/Upgrades>
www.pmwiki.org
PmWiki is designed to make it easy to upgrade the PmWiki software without affecting your existing data files or installation. For most upgrades, you simply copy the ...




On 2017-07-06 21:15, Monte Padget wrote:
> The following is the information from test site.
>
>
> Server: 000webhost
>
> PmWiki: pmwiki-2.2.99
>
> PHP: 7.1.6
>
> Attachtable: attachtable-php55.zip with attachtable-getid3-more.tar.gz
>
> Added to config.php (sample-config.php copied to local and renamed):
>
> $WikiTitle = 'TestWiki';
>
> $UploadPrefixFmt = '/$Group/$Name';
> $UploadMaxSize = 5000000;
>
> $EnablePathInfo = 1;
>
> $DefaultPasswords['admin'] = pmcrypt('secret');
>
> $EnableGUIButtons = 1;
>
>
> $WikiTitle = 'TestWiki';
>
> $EnableUpload = 1;
> $UploadPermAdd = 0;
> $DefaultPasswords['upload'] = pmcrypt('secret');
>
> switch($action) {
>   case 'delattach':
>   case 'renameattach':
>   case 'downloaddeleted':
>
> include_once("$FarmD/cookbook/attachtable/attachtable-actions.php");
>     break;
>   case 'fileinfo':
>   case 'thumbnail':
>     include_once("$FarmD/cookbook/attachtable/fileinfo.php");
>     break;
>   case 'upload':
>   default:
>     include_once("$FarmD/cookbook/attachtable/attachtable.php");
>     break;
> }
>
>
> WikiSandbox (-> Works verified files in the uploads/Main/WikiSandbox
> directory):
>
> Attach:bd1b2eaac1ee68222e2c74b693aec3b1.jpg\\
>
> Attach:landing_bg.jpg\\
>
> Attach:bg_newsletter_1483052655.jpg\\
>
>
> Addition of following to WikiSandbox (-> Save gives blank screen,
> preview shows correctly);
>
> (:attachtable:)
>
>
> Source Images:
>
>
> https://s-media-cache-ak0.pinimg.com/736x/bd/1b/2e/bd1b2eaac1ee68222e2c74b693aec3b1.jpg

[https://s-media-cache-ak0.pinimg.com/736x/bd/1b/2e/bd1b2eaac1ee68222e2c74b693aec3b1.jpg]

> https://bubbleup.vo.llnwd.net/o2/margaritaville/margaritaville2014/landing_bg.jpg

[https://bubbleup.vo.llnwd.net/o2/margaritaville/margaritaville2014/landing_bg.jpg]

> https://s3.amazonaws.com/busites_www/mville2017/user_data/5/uploads/bg_newsletter_1483052655.jpg

[https://s3.amazonaws.com/busites_www/mville2017/user_data/5/uploads/bg_newsletter_1483052655.jpg]

>
>
>
> ________________________________
> From: pmwiki-users <pmwiki-users-bounces at pmichaud.com> on behalf of
> Monte Padget <m_padget at hotmail.com>
> Sent: Thursday, July 6, 2017 2:20 PM
> To: pmwiki-users at pmichaud.com
> Subject: Re: [pmwiki-users] Cookbook Recipe Attachtable problem
>
>
> I have started a fresh install on 000webhost with pmwiki-2.2.99.
>
>
> I'll start setting up a new one from scratch to see what I can find.
> I'll post what I find.
>
>
> I wasn't listing any audio files, the only ones I had so far where a
> couple of image files.
>
>
> Thanks,
>
> Monte
>
>
> ________________________________
> From: pmwiki-users <pmwiki-users-bounces at pmichaud.com> on behalf of
> Petko Yotov <5ko at 5ko.fr>
> Sent: Thursday, July 6, 2017 12:57 PM
> To: pmwiki-users at pmichaud.com
> Subject: Re: [pmwiki-users] Cookbook Recipe Attachtable problem
>
> You don't mention your PmWiki version and your PHP version. I assume
> you
> installed the latest PmWiki version.
>
> These symptoms suggest an older PmWiki installation, and/or an older
> recipe that calls the function "htmlspecialchars" directly, while the
> text contains what PHP considers invalid bytes. See:
>
>    http://www.pmwiki.org/wiki/PmWiki/Troubleshooting#blank_sections
PmWiki | PmWiki / Troubleshooting<http://www.pmwiki.org/wiki/PmWiki/Troubleshooting#blank_sections>
www.pmwiki.org
PmWiki is pretty robust and can automatically adapt to a very wide variety of environments. However, sometimes things don't go as we expect, so we're cataloging ...


>
> PmWiki | PmWiki /
> Troubleshooting<http://www.pmwiki.org/wiki/PmWiki/Troubleshooting#blank_sections>
PmWiki | PmWiki / Troubleshooting<http://www.pmwiki.org/wiki/PmWiki/Troubleshooting#blank_sections>
www.pmwiki.org
PmWiki is pretty robust and can automatically adapt to a very wide variety of environments. However, sometimes things don't go as we expect, so we're cataloging ...


> www.pmwiki.org<http://www.pmwiki.org>
> PmWiki is pretty robust and can automatically adapt to a very wide
> variety of environments. However, sometimes things don't go as we
> expect, so we're cataloging ...
>
>
>
>
> Attachtable doesn't appear to call this function but the file
> getid3.lib.php calls "htmlentities" 3 times and it may also suffer from
> the bug - I suspect it may happen if you list audio/video files whose
> metadata has a different charset than the wiki.
>
> It could be another recipe or a skin. To check it, disable all recipes
> then test the wiki: if the bug persists, it could be a PmWiki bug and
> I'd be very interested to test and review that installation and fix the
> bug. Re-enable one recipe at a time and check the wiki for the bug: at
> some point it will re-appear and you'll know the recipe you just
> enabled
> is the culprit. There may be more than one -- we can fix them all.
>
> Petko
>
> On 2017-07-06 17:38, Monte Padget wrote:
>> I am able to preview the (:attachtable:) and it shows correctly, but
>> if I try to save, the page is blank. Not sure what I'm missing at this
>> point. I'll post more when I can find something.
>>
>>
>> Been reading through the Talk page, but unable to find what I need.
>>
>>
>> Are there any nuggets of wisdom that I might be missing?
>>
>>
>> -Monte
>>
>>
>> ________________________________
>> From: pmwiki-users <pmwiki-users-bounces at pmichaud.com> on behalf of
>> Monte Padget <m_padget at hotmail.com>
>> Sent: Thursday, July 6, 2017 10:48 AM
>> To: Pmwiki-users at pmichaud.com
>> Subject: Re: [pmwiki-users] Cookbook Recipe Attachtable problem
>>
>>
>> I think I found a problem. With all the checking I was doing, I had
>> commented out the password at some point and forgot to un-comment. I'm
>> not sure if it is completely working yet, but it is progressing again.
>>
>>
>> Thanks,
>>
>> Monte
>>
>>
>> ________________________________
>> From: pmwiki-users <pmwiki-users-bounces at pmichaud.com> on behalf of
>> Monte Padget <m_padget at hotmail.com>
>> Sent: Thursday, July 6, 2017 9:48 AM
>> To: Pmwiki-users at pmichaud.com
>> Subject: [pmwiki-users] Cookbook Recipe Attachtable problem
>>
>>
>> I'm in the process of setting up a site on 000webhost and am having
>> problems getting the Cookbook Recipe Attachtable to work.
>>
>>
>> This recipe I have used in the past and want to use it still, but the
>> wiki won't load.
>>
>>
>> Following the steps, when I get to the step to edit the
>> Site.UploadQuickReference, I am not able to edit. I am prompted for
>> the password, but it won't go beyond that screen. I have verified my
>> password several times, I have verified the permissions of the wiki.d
>> directory. I do have uploads allowed. Could that be the problem? Not
>> being allowed to edit this Site?
>>
>>
>> -Monte
>
> _______________________________________________
> pmwiki-users mailing list
> pmwiki-users at pmichaud.com
> http://www.pmichaud.com/mailman/listinfo/pmwiki-users
>
> pmwiki-users Info
> Page<http://www.pmichaud.com/mailman/listinfo/pmwiki-users>
> www.pmichaud.com<http://www.pmichaud.com>
> To see the collection of prior postings to the list, visit the
> pmwiki-users Archives. Using pmwiki-users: To post a message to all
> the list members ...
>
>
>
>
> _______________________________________________
> pmwiki-users mailing list
> pmwiki-users at pmichaud.com
> http://www.pmichaud.com/mailman/listinfo/pmwiki-users

_______________________________________________
pmwiki-users mailing list
pmwiki-users at pmichaud.com
http://www.pmichaud.com/mailman/listinfo/pmwiki-users
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.pmichaud.com/pipermail/pmwiki-users/attachments/20170706/0f0a2a45/attachment-0001.html>


More information about the pmwiki-users mailing list