[pmwiki-users] need expert review - multilanguage recipe change

[Hans]

Thursday, July 16, 2009, 10:04:44 AM, SteP wrote:


> What advantage can you see in using the above vs.
>
> (:if userlang de:)(:title Eine deutsche Überschrift:)...

None really. My mistake. Forget the suggestion.

> For review: diff of local/multilanguage.php
> 1c1
> <       function MultiLanguageTitle($pn,$name) {
> ---
>>       function MultiLanguageTitle($pn,$name,$group) { //SteP added $group
> 4a5,6
>>               if ( $pn != "$group.$name" ) //SteP added
>>                       $pn = MakePageName("$group.$name","$group.$name"); //SteP added, would 
> $pn = "$group.$name"; be better?

I reviewed multilanguage.php  function MultiLanguageTitle
and suggest the following change:

change code lines 121 to 127
..........
  $FmtPV['$Title'] = 'MultiLanguageTitle($pagename, $group, $name)';
  $FmtPV['$Titlespaced'] =
        '$AsSpacedFunction(MultiLanguageTitle($pagename, $group, $name))';
  $FmtPV['$userlang'] = "'$userlang'";

function MultiLanguageTitle($pagename, $group, $name) {
  global $PCache, $userlang, $DefaultLanguages, $AsSpacedFunction;
  $pn = MakePageName($pagename, $group.".".$name);
  if (!PageExists($pn)) return '';
..........


  ~Hans