[pmwiki-users] AddDeleteLine 2.0beta6

[Pico]

Martin Fick wrote:
> On Sunday 24 September 2006 06:34, you wrote:
> 
>>> I will also send you a working addition of multi values which needs (and
>>> includes) the above mentioned fixes to work  (2.0beta6M2).  
> ...
>> There's a problem with the (:adl delrange:) and the (:adl delete:)
>> statement. The purpose of $linekey is, to create a unique ID for each 
>> entry, so  that the AdlDeleteHandler is able to identify the range or the
>> line of the delete-button that has  been pressed. Your code is now 
>> using the same $linekey for all entries that have been  added due the 
>> to array field.  This means, if you have a (:delete:)-button in there, it
>> will remove all  entries. This is probably not what you want, or at 
>> least it is not what I would expect. 
>> I feel the urge to fix that somehow, but I actually have to do something
>> else, so can you have a look at it?
> 
> Well I can probably fix that if you want.  I have no need to delete in my
> case, and I can see a valid desire to do it both ways:  deleting lines 
> individually or all together since it was one submission.  Not having a need 
> for the delete myself in this case, I think it might be hard to predict 
> the "correct" behavior, maybe both should be possible.  I will look into it 
> more. Feel free to hold off on incorporating the multi insertion changes 
> until a better delete solution is proposed/achieved.
>> 
[snip]

FWIW I keep thinking of this as a real bare bones scaled down shopping 
cart that facilitates adding and deleting links to a page so that the 
trail on that page can be used for further processing.  Maybe there are 
some common solutions to share.  (Or, in my view, this add delete could 
be a real basic foundation that helps those who want to pursue a 
shopping cart that makes greater use of PmWiki.


Pico
-- 

         __  /
        /   /
       /___/ _/  ___/  __  /
      /      /  /     /   /
    _/     _/  ____/ ____/

 >>>===pmwiki at ben-amotz.com===>