[pmwiki-users] Update Attachments

Patrick R. Michaud pmichaud at pobox.com
Fri Feb 3 10:54:34 CST 2006


On Fri, Feb 03, 2006 at 05:29:17PM +0100, Dominique Faure wrote:
> 2006/2/3, Patrick R. Michaud <pmichaud at pobox.com>:
> > Still better would be for monobook.php to use the SDV() function to
> > set these values, which would allow the admin to set a preference
> > over the skin's defaults.
> >
> > SDV($IMapLinkFmt['Attach:'],
> >   "<a class='attachlink' href='\$LinkUrl' rel='nofollow'>\$LinkText</a>");
> > SDV($LinkUploadCreateFmt,
> >   "<a class='createlinkupload' href='\$LinkUpload'>\$LinkText</a>");
> > SDV($LinkPageCreateFmt,
> >   "<a class='createlinktext' href='\$PageUrl?action=edit'>\$LinkText</a>");
> >
> 
> That's why, among others, I'm updating it... ;)
> But $LinkPage...Fmt and $UrlLinkFmt are neither being initialized
> using SDV() in pmwiki.php (lines 81-88).

Oops, you're correct, it won't do any good to use SDV()
on $LinkPageCreateFmt, since it is already initialized by pmwiki.php.
Still, it's a good idea to use SDV() for the other two variables.

PmWiki doesn't use SDV() for $LinkPage...Fmt and $UrlLinkFmt because
because they're initialized before local customizations are loaded 
(thus SDV doesn't accomplish anything here).

Pm




More information about the pmwiki-users mailing list