[pmwiki-users] very small definition list (mis-)feature request

Patrick R. Michaud pmichaud at pobox.com
Thu Sep 28 18:18:17 CDT 2006

On Fri, Sep 29, 2006 at 09:57:22AM +1200, John Rankin wrote:
> While browsing pmwiki.php 2.1.25 source (as you do), 
> I noticed near the end of function Block the line:
>     $out .= ... .'<dd>';
> Whatever this does, it will break wikipublisher.

Wow, is *that* still there?!?  ;-)

I  think  this is handling the case where the markup "skips"
an indent level, as in:

    * This is a first-level list item
    *** This is a third-level list item

What I think I was doing here is using an extra <dl>...</dl>
item to achieve the extra level of nested indent.  Arguably
this is very incorrect from an HTML/semantic point of view.
It also pre-dates the time when we had the ---> indent markup
available, which would arguably be a lot more correct and would
avoid the problem of the hardcoded <dd>.

So, I propose to switch the Block function to use <div class='indent'>
instead of <dl> for any skipped indentation levels.  This would
entirely eliminate the need for the hardcoded <dd> tag, make
the overall HTML cleaner, and move PmWiki even closer to being
markup agnostic.

Does that work?


More information about the pmwiki-users mailing list