[pmwiki-users] Problems with the embedded CSS in pmwiki.php

[marc]

Ben Wilson said...
> I'm coming very late to this discussion. To me, this is not an issue,
> and I'll show why . . .
> 
> On 10/29/06, marc <gmane at auxbuss.com> wrote:
> > In the recommended case:
> >
> >   <link rel='stylesheet' title="Skinname"
> >      href='$SkinDirUrl/Skinname.css' type='text/css' />
> >   <!--HTMLHeader-->
> >   </head>
> 
> What I do is:
> 
> <!--HTMLHeader-->
> <link ... href='$SkinDirUrl/media.css' type='text/css' />

Hi Ben,

Yup, but this breaks local customization and pub/local.css
 
> I've done this since for skins where it matters.  If you've not
> noticed, I put the PmWiki-added material before my skin CSS. In CSS,
> last-in-time wins. So, it matters not what PmWiki markup tells the
> skin to do---if my skin says something else it wins. And, of course,
> this works for any recipe that adds CSS via HTMLHeader.

Yup, but the skin shouldn't beat local customization and pub/local.css - 
which are generated by HTMLHEader - although it should beat PmWiki, so 
to speak, imo.

Patrick has already detailed the most appropriate way to meet the above:

  global $HTMLHeaderFmt;
  $HTMLHeaderFmt['skin'] = 
    "<link rel='stylesheet' type='text/css'
  href='\$SkinDirUrl/skin.css' title='Skin' />\n";

in skin.php. The debate has moved on from there to considering whether a 
"core" PmWiki CSS file is "better", all things considered.

-- 
Best,
Marc