[pmwiki-users] 2.1-b37 Cached page (?) issue

Patrick R. Michaud pmichaud at pobox.com
Thu Mar 9 08:37:36 CST 2006

On Thu, Mar 09, 2006 at 04:13:20PM +0200, Athan wrote:
> "Patrick R. Michaud" <pmichaud at pobox.com> wrote in message 
> news:20060309135307.GB31073 at host.pmichaud.com...
> > Which page did you select from the search results of your first search?
> >
> > (Yes, the page you selected makes a difference.)
> Hmm, it happened with a few pages I've tried but not remembered which of 
> them had that problem.
> Just found one
> PmWiki.ChangeLog

Yes, that's what is going on here.  If one does a search from any page that
has a (:searchresults:) directive on it (which PmWiki.ChangeLog does
at the moment), then instead of getting the normal search results
page contents we get the current page back with the (:searchresults:)
directive replaced by the results of the search.  This allows authors
to create custom search results pages.  

Unfortunately, the ?action=search code doesn't (yet) understand
escaping of (:searchresults:), and so even the search results are
being suppressed.

I'll fix the ?action=search code to be smarter about finding
(:searchresults:) directives, and we need to make sure that
any instances of (:searchresults:) in the ChangeLog (and other
pages) are properly escaped.  

We probably need to do a search for (:searchresults:).  Boy, does
that sound scary.  :-)

> PS: I've corrected some validation and localization mistakes in print.tmpl 
> and XLPageTemplate. Could you please review this entry in PITS 
> http://www.pmwiki.org/wiki/PITS/00690

Will do.  A quick way to have a page get my attention is to
put an [[!Update me]] category tag on it.  :-)


More information about the pmwiki-users mailing list