[pmwiki-users] A skin is changing $LinkPageSelfFmt

[Hans]

Friday, December 15, 2006, 8:23:06 PM, JB wrote:

> Skins are to change the look and feel of the pages.

> There is a skin that sets the variable "$LinkPageSelfFmt".

>      # changes to extended markup recipe for selflink definition:
>      global $LinkPageSelfFmt;
>      $LinkPageSelfFmt = "<a class='selflink'>\$LinkText</a>";

> Somehow I don't think a skin should be setting a variable
> like this.

Would you care to explain please?
Should in your opinion a skin not set $LinkPageSelfFmt, and why not?
Or is the above example objectionable, could it be improved?

I set $LinkPageSelfFmt to override a $LinkPageSelfFmt setting from
extendmarkup.php, which just rendered links in the SideBar not to my
liking, as bold black text, dotted underlined.

PmWiki sets $LinkPageSelfFmt not as a SDV variable, so any recipe or
skin needing/wanting to change this can't use SDV either.
PmWiki sets $LinkPageSelfFmt as a link, so you have the paradox
situation to see a link to a page in the sidebar, which you are already
on. I do not agree with this (as does Markup Extensions), and so I
redefined it. Some admins like it this way, a few asked how to change
it. I think it should become a SDV variable, and all recipes wishing
to set it would use SDV as well, and then an admin can set
it in config.php if she/he wishes.


Hans