[pmwiki-users] Problem with URLapprove
Patrick R. Michaud
pmichaud at pobox.com
Mon Jun 13 15:23:35 CDT 2005
On Mon, Jun 13, 2005 at 09:47:59PM +0200, chr at home.se wrote:
> Hi Patrick
> I've got a problem with urlapprove that I'm currently debugging. The first
> thing I noticed was this in urlapprove.php
> $ApprovedUrlPagesFmt = array('Main.ApprovedUrls');
> How come you're not using SDVA($Approve...) for this?
I dunno, I should probably fix this.
> The second thing I wonder is why you've got 'Main' hardcoded? If this
> shouldn't be the same as $DefaultGroup, I really think we should introduce
> a separate variable name for this - if nothing else, $MainGroup,
> $ConfigGroup or $SiteGroup. I think we had this discussion a while back,
> but I can't remember any of the useful names we came up with.
Well, it all comes down to the same thing as has been discussed before...
Suppose we use $DefaultGroup instead of 'Main', and someone has been
running a PmWiki site for a while with the PmWiki defaults (common).
Then one day they decide they really want to have people start in the
'XYZ' group instead of 'Main', so they set $DefaultGroup='XYZ' in
config.php, and later discover:
- the sidebar is gone on many pages
- searches no longer go to the search page
- urls are no longer approved
- Main.AllRecentChanges is no longer being updated
It just ends up being too many things tied to what new administrators
expect $DefaultGroup to do.
However, since since lots of people seem to want to easily move things
from Main into other groups, I'm open to introducing another variable
(along the lines of $MainGroup, $UtilGroup, or $SiteGroup) that indicates
the group where these "utility" pages are being kept. It'd still be
up to the admin to actually move things into the new group when
the variable is changed.
More information about the pmwiki-users