[pmwiki-users] Re: Tricky issue with approveUrl and included pages

[chr at home.se]

On Sun, 11 Dec 2005, Patrick R. Michaud wrote:

> On Sat, Dec 03, 2005 at 11:10:59AM +0100, chr at home.se wrote:
> > What was really happening here was that the external links came from a
> > page that was *included* to the main page... so approveUrl naturally never
> > even saw these links. I'm not exactly new to pmwiki, but this have had me
> > fooled for weeks (partly because it's a new site and I thought it was some
> > special bug in my setup due to shared groups and whatnot).
> > 
> > Anyway, could this situation be improved? For instance, what if approveUrl
> > were to look for (:include:) in the page, and if the page does include
> > other pages, the script would simply issue a small warning message.  
> 
> Looking only for (:include:) might not be enough -- it would still
> miss links coming from GroupHeader and GroupFooter, as well as 
> other recipes that include contents (e.g., PmCalendar).

Here's a general thought. What if the include mechanisms for generating
the web page made a note of what pages (parts of pages?) that were used in
the process? Either by just adding the information to an array, or perhaps
even embedding it in the generated HTML? I have a feeling that there are 
other situations where you might be interested in knowing what wiki pages 
were used to produce the current web page.

> > Thinking even further along this line, what if we always got a (temporary)  
> > message after performing approveUrl? Perhaps it could look something like
> > this:
> > 
> > 	The following external links were found in the page <page> and
> > 	and have now been approved:
> > 	* http://...
> 
> Personally, I like that I'm instantly returned back to the page with the
> links all approved -- this keeps the number of involved clicks to a
> minimum (and I think url approval needs to be kept as unintrusive as
> possible).

With "temporary" I actually meant that this should be only shown for a 
little while. (And a clickable link to expedite things if so desired)

>  But we could probably make it into an option.

How about making the duration the option? '0' would mean just skip it, and 
a positive number would indicate how many seconds it is to be shown. I'm 
assuming this can be easily done using the default refresh/redirect 
mechanism.

> > 	See [[PmWiki.ApproveUrls]] for further details.
> > 
> > Thoughts?
> 
> Perhaps it would be sufficient if the handling of include pages
> and approvals was documented somewhere, or placed in a FAQ.

A big maybe... 

/C

-- 
Christian Ridderström, +46-8-768 39 44               http://www.md.kth.se/~chr