[Pmwiki-users] page revisions not working
Clinton R. Nixon
Wed Oct 8 09:33:49 CDT 2003
Jonathan Scott Duff said:
> This does not do what you think it does. The entire while loop is
> essentially a NOOP since you've opened the IN file handle as an
> *output* pipe.
> Why not just use system() from within perl?
> system "/usr/bin/patch", $q->param('txtfile'), $q->param('patfile');
> And you should check the return value of your open() or system() to
> see if it succeeded or not.
Good call. It was a quick and dirty 5-minute solution, works, and was
posted in order that someone else might improve it and use it when they
find themselves in the same situation.
More information about the pmwiki-users