[pmwiki-devel] Highslide update for PHP5.5?

Petko Yotov 5ko at 5ko.fr
Tue Sep 8 08:30:19 CDT 2015


On 2015-09-08 14:24, Russ wrote:
> Would anyone be able to take a look at the Highslide recipe to make it
> compatible with PHP5.5? I'm also happy to throw a few dollars at it if
> it needs to be a small paid job (if so, just let me know how much).

The following line 72 in highslide.php:

   Markup('highslide', 'block', '/\\(:highslide(?:\\s+(.*?))?:\\)/ei',
     "MakeHighslideScript(PSS('$1'))");

should be changed to:

   Markup_e('highslide', 'block', '/\\(:highslide(?:\\s+(.*?))?:\\)/i',
     "MakeHighslideScript(\$m[1])");

This is only the PmWiki part of the code and should fix any warnings 
about preg_replace. I haven't tested the JavaScript part.

Normally, you should ask the author to update his recipe. If he cannot, 
as the Beerware license permits it, you can release and support a new 
version yourself.

Petko

-- 
Change log     :  http://www.pmwiki.org/wiki/PmWiki/ChangeLog
Release notes  :  http://www.pmwiki.org/wiki/PmWiki/ReleaseNotes
If you upgrade :  http://www.pmwiki.org/wiki/PmWiki/Upgrades

If this message helped you and saved you time, feel free to make
a small contribution: ♥ http://5ko.fr/donate-ml (mailing list).




More information about the pmwiki-devel mailing list