[pmwiki-devel] $UploadNameChars

[Petko Yotov]

On Wednesday 23 May 2012 20:08:19 Simon wrote:
> As PmWiki generates the URLs should it not escape the characters as part of
> the generation?

You can get the pre-release from subversion and test it:
  http://www.pmwiki.org/wiki/PmWiki/Subversion

Only scripts/upload.php changed from 2.2.38. Only the (:attachlist:) markup 
should be expected to work, other recipes dealing with uploads may use their 
own ways.

However, if you can, I strongly recommend to get rid of the additional 
characters in your filenames, because of many potential conflicts. See
  http://www.pmwiki.org/wiki/PmWiki/UploadVariables#UploadNameChars

Unfortunately I don't have enough resources to fix unsupported stuff when, 
not if, something else breaks because of the unsupported filenames. (The 
additional characters, even if they appear to work now, are still not 
recommended.)

Petko

> On 23 May 2012 00:41, Patrick R. Michaud <pmichaud at pobox.com> wrote:
> > On Tue, May 22, 2012 at 09:51:17PM +1200, Simon wrote:
> > > I have
> > > 
> > > *$UploadNameChars = "-\w. !=+#";** # allow exclamations, equals,
> > > plus,
> > 
> > and
> > 
> > > hash*
> > > 
> > > This means I can successfully upload files such as
> > > http://kiwiwiki.co.nz/pmwiki/pmwiki.php/Test/UploadNameChars?upname=
> > > *
> > > File#1.txt*&action=upload
> > > [...]
> > > However when I try to download the file
> > 
> > http://kiwiwiki.co.nz/pmwiki/pmwiki.php/Test/UploadNameChars?action=down
> > load&upname=> 
> > > *File#1.tx*t
> > 
> > Note that '#' has to be escaped in URLs, otherwise it's taken as an
> > anchor marker by the browser and stripped before it's sent to PmWiki. 
> > In other words, the urls need to be
> > 
> > 
> > http://kiwiwiki.co.nz/pmwiki/pmwiki.php/Test/UploadNameChars?upname=*Fil
> > e%231.txt*&action=upload
> > 
> > and
> > 
> > 
> > http://kiwiwiki.co.nz/pmwiki/pmwiki.php/Test/UploadNameChars?action=down
> > load&upname=*File%231.txt*
> > 
> > The same thing is true for many of the other characters you're allowing;
> > be sure they're properly encoded in urls.
> > 
> > Pm