[pmwiki-devel] fix: forms.php -- select list default on reload

[DaveG]

I'll check the SVN version, but this is a different issue to the 
typo-issue. The typo-issue was for ensuring values were defaulted.

On my local copy, with the typo-issue fix, I needed to apply this larger 
patch in order to ensure that user-entered values are re-posted on 
error, rather then re-displaying the currently stored values.

  ~ ~ Dave

Petko Yotov wrote:
> On Friday 20 February 2009 16:09:40 DaveG wrote:
>> When the form reads values from a source, and is being reloaded due to
>> an entry error, the user values are over-ridden by the values in the
>> source file. Thus, select lists return to their original source file
>> values, rather than retaining the values selected by the user.
> 
> Hi Dave,
> 
> I was unable reproduce the problem with the SVN version, probably it is the 
> same we fixed a while ago?
> 
> There was a typo, left when $PageTextVarPatterns keys were switched from the 
> first to the second match of the RegExp.
> 
> You reported this a while ago and I fixed it in SVN : around line 178:
> 
>   if (!isset($InputValues['ptv_'.$m[2]]))
>     $InputValues['ptv_'.$m[2]] =
>       htmlspecialchars(Qualify($source, $m[3]), ENT_NOQUOTES);
> 
> Could you please check if the fixed version still has the bug, and if yes, 
> we'll investigate further.
> 
> Thanks,
> Petko
>