[pmwiki-devel] [patch] New function in pagerev.php

[Daniel Roesler]

Howdy all,

In light of recent discussion on how to propose patches/changes to
PmWiki, I've added a PITS entry for the hook patch I proposed a few
months ago. If you have any questions, I will be happy to discuss them
on that page or on this mailing list.

http://www.pmwiki.org/wiki/PITS/01106

Avast!
Daniel Roesler
diafygi at gmail.com

On Thu, Apr 23, 2009 at 4:04 PM, Daniel Roesler<diafygi at gmail.com> wrote:
> Howdy all,
>
> I've attached a patch that basically moves a bit of code out of the
> PrintDiff() function in /scripts/pagerev.php to it's own function.
> Originally, the rendering of the diff code from page histories was
> handled within PrintDiff() function. However, this limits the
> rendering of that code to only History pages (?action=diff) which
> means that recipes can't utilize this the same rendering without
> basically duplicating the internal code (bad for upgrades, security,
> size, etc.). So I removed the diff rendering part and put it in it's
> own function called RenderDiff(). Unfortunately, I couldn't just
> create a new recipe that adds the function because PrintDiff()
> wouldn't utilize it. I've attached the new php file and a diff file.
>
> Avast!
> Daniel Roesler
> diafygi at gmail.com
>